Fix thread sources for legacy WASI target - #879
Open
chenrui333 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
2 tasks
Collaborator
|
Thanks! While this works though, could the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake thread-source selection recognizes
wasm32-wasip1-threadsbut misses its legacy aliaswasm32-wasi-threads. The latter receives the single-threaded stubs even though the rest of the build enables thread support.Accept both spellings so the legacy target includes the real pthread and futex implementation. Reproduced the missing-symbol failure with
CHECK_SYMBOLS=ON; both target spellings pass the symbol check after this change using Clang 23 on macOS arm64.Found while building wasi-sdk-34 for Homebrew/homebrew-core#301216.