Conversation
Co-authored-by: Craig <sandedshoes@gmail.com>
…urn back on when destination already reached. (#610) Co-authored-by: River <34910888+CommandrMoose@users.noreply.github.com>
…rottle is set to 0 before dematerialization is complete. (#608) Co-authored-by: River <34910888+CommandrMoose@users.noreply.github.com>
Co-authored-by: River <34910888+CommandrMoose@users.noreply.github.com>
…ults more dynamic. (#614)
| if(ModCompatChecker.immersivePortals() && ImmersivePortals.isTeleportingPortalPresent(shellBlockEntity.getTardisId())){ | ||
| return Shapes.empty(); | ||
| } | ||
|
|
There was a problem hiding this comment.
With this we can probably remove my IP_VS_COLLISION config check just below this (in hindsight we should probably move that config to SERVER anyway (we can't remove it completely since the interior door is still using it right now, but maybe we can just remove the collision box for the interior door as well and get rid of the config?), I didn't realise Forge Config API had automatic config sync for SERVER configs when I wrote this code). I can fix that later though.
There was a problem hiding this comment.
Actually, I found a bug here. It's the same bug which I have a fix for in #625, but it happens every time a TARDIS is created.
Basically, when creating the TARDIS, the dimension parameter will be null, and isTeleportingPortalPresent expects a not null value.
There was a problem hiding this comment.
If we merge both this and #625 it should just solve itself though.
| /* if (ModCompatChecker.create()) { | ||
| CreateIntergrationsInit.init(); | ||
| } | ||
| }*/ |
There was a problem hiding this comment.
Umm... Any particular reason why you disabled the Create compatibility?
There was a problem hiding this comment.
I will correct this, I was making a build for someone who was using a older create version, pay it no mind
|
Welp, I think this is good enough to merge, probably. I only found one bug which should fix itself once we merge one of my other PRs. |
2 participants
Started on this a while ago and rewrite the Gravity Shaft UI and the Shell View UI
Ended up fixing IP placements, bon appetite
Note: As @Acuadragon100 has committed a lot I have had to merge his changes in and had merge conflicts, would benefit from a closer view to ensure his changes got in