Skip to content

chore: remove unused pruneCollectionsFileStrict method - #253

Open
detail-app[bot] wants to merge 1 commit into
devfrom
detail/dead-code/chore-remove-unused-prunecollectionsfilestrict-met-b70cfd
Open

detail-app[bot] wants to merge 1 commit into
devfrom
detail/dead-code/chore-remove-unused-prunecollectionsfilestrict-met-b70cfd

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Removes the plural-collections pruneCollectionsFileStrict public method
from IngestedFilePruneService along with the two tests that exclusively
exercised it and the imports/constant that were only used by those tests.

The method had no production callers. Git history shows it was introduced
with a caller in LocalDocsFileIngestionProcessor (commit e904faf), which
was then removed ~8 hours later by a refactor (commit 1263e64) that switched
the processor to the per-collection pruneCollectionFileStrict variant.
The orphaned method was left behind with no production references — only
tests. The superseding singular variant and all private helpers it shares
remain untouched.

  • drop pruneCollectionsFileStrict and its Javadoc
  • drop the two pruneCollectionsFileStrict-only tests and now-unused
    assertThrows, doThrow, inOrder, InOrder imports and
    BOOKS_COLLECTION_NAME constant

History


Dead Code PRs can be configured here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant