chore: remove unused pruneCollectionsFileStrict method - #253
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the plural-collections
pruneCollectionsFileStrictpublic methodfrom
IngestedFilePruneServicealong with the two tests that exclusivelyexercised it and the imports/constant that were only used by those tests.
The method had no production callers. Git history shows it was introduced
with a caller in
LocalDocsFileIngestionProcessor(commit e904faf), whichwas then removed ~8 hours later by a refactor (commit 1263e64) that switched
the processor to the per-collection
pruneCollectionFileStrictvariant.The orphaned method was left behind with no production references — only
tests. The superseding singular variant and all private helpers it shares
remain untouched.
pruneCollectionsFileStrictand its JavadocpruneCollectionsFileStrict-only tests and now-unusedassertThrows,doThrow,inOrder,InOrderimports andBOOKS_COLLECTION_NAMEconstantHistory
Dead Code PRs can be configured here.