fix: satisfy current Clippy lint for brightness icon - #189
Merged
Merged
Conversation
Signed-off-by: FoOcean <foocean@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
CONTRIBUTING.mdand completed the required checksChange type (select one)
featNew featurefixBug fixdocsDocumentation or templatesstyleFormatting with no behavior changerefactorCode change that neither fixes a bug nor adds a featureperfPerformance improvementtestTest-related changechoreBuild, CI, dependency, or tooling changerevertRevertsecuritySecurity fixScope (select all that apply)
Related issues
Follow-up to #188.
Description
Summary
Use the current Clippy-recommended four-byte chunk iteration for brightness icon pixels.
Motivation and context
The GitHub Actions runner uses Rust 1.98, which rejects
chunks_exact_mut(4)with-D warnings. The locally installed Rust 1.96 did not flag it, so this one-line compatibility fix is needed before the 1.3.9 release workflow runs.Changes
chunks_exact_mut(4)withas_chunks_mut::<4>().0in the brightness icon conversion loop.UI changes
No visible UI changes.
Validation:
cargo fmt --all,cargo clippy --workspace --offline -- -D warnings, andcargo build --release --offlinepassed locally. The prior GitHub Actions log showed only the Rust 1.98 lint error addressed here.