WordPress.tv: Fix subtitle upload error on cached/unauthenticated submissions - #820
Open
wprashed wants to merge 2 commits into
Open
WordPress.tv: Fix subtitle upload error on cached/unauthenticated submissions#820wprashed wants to merge 2 commits into
wprashed wants to merge 2 commits into
Conversation
Prevent unauthenticated subtitle uploads with a valid username from failing due to stale or cached nonces, and send nocache headers on the subtitle upload page. Fixes https://meta.trac.wordpress.org/ticket/8406 Props sebastienserre, wprashed.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://meta.trac.wordpress.org/ticket/8406
Description
When submitting subtitles via
/subtitle/?video=..., unauthenticated users or users with stale nonces (due to page caching or browser cache differences such as on Firefox) encounteredInvalid form data. Please go back and try again..This mirrors the handling in
anon-upload.phpby ensuring unauthenticated submissions providing a WordPress.org username are not blocked by stale nonces, and addsnocache_headers()toupload-subtitles-template.phpto prevent caching of the subtitle submission form.Props
Props @sebastienserre, @wprashed.