Implementing suggested code changes from ticket #2076 - #2077
Merged
RobertvanderHulst merged 1 commit intoSep 3, 2026
Conversation
…er /shared Co-authored-by: RobertvanderHulst <14240939+RobertvanderHulst@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
RobertvanderHulst
September 3, 2026 07:10
View session
RobertvanderHulst
approved these changes
Sep 3, 2026
RobertvanderHulst
approved these changes
Sep 3, 2026
RobertvanderHulst
marked this pull request as ready for review
September 3, 2026 07:13
RobertvanderHulst
approved these changes
Sep 3, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped and directly addresses the documented concurrency issue without introducing additional behavioral changes outside the parser state storage.
Pull request overview
This PR updates the X# extensions to Roslyn’s CSharpCommandLineParser so the mutable X# per-parse option state is no longer shared across concurrent compilations when using the process-wide CSharpCommandLineParser.Default singleton (notably under /shared compiler server scenarios).
Changes:
- Replaced the instance field used for X# per-parse state with a
[ThreadStatic]backing field to prevent cross-thread state corruption. - Added lazy initialization via a private
optionsproperty wrapper, keeping existing call sites intact.
File summaries
| File | Description |
|---|---|
| src/Compiler/src/Compiler/XSharpCodeAnalysis/CommandLine/XSharpCommandLineParser.cs | Makes X# command-line parsing state thread-isolated to avoid concurrency corruption when parsing via CSharpCommandLineParser.Default. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent