Fixes version retrieval during package builds causing KeyError on installation - #766
Open
syed177013 wants to merge 1 commit into
Open
Fixes version retrieval during package builds causing KeyError on installation#766syed177013 wants to merge 1 commit into
syed177013 wants to merge 1 commit into
Conversation
Fixes a KeyError: '__version__' when installing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a KeyError: 'version' that can occur when installing BasicSR during package metadata generation.
The issue occurs in get_version(), which previously relied on locals() to retrieve version after executing the generated basicsr/version.py.
-Updated
get_version()to execute the generated version file in an explicit namespace and retrieve__version__from that namespace directly.-Ensured
write_version_py()runs during the package build process so that the generated version file is available whenget_version()is called.After the changes:
-python -m pip install . successfully builds and installs BasicSR.
-import basicsr; print(basicsr.version) successfully reports the package version.
-Torch and Torchvision imports continue to work correctly.
This is a minimal packaging focused change and does not alter BasicSR's runtime functionality.