feat: Add public routes in tanstack start - #766
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a0800d472
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export const myFilesQueryKey = (params: MyFilesParams) => | ||
| [...MY_FILES_QUERY_ROOT, params] as const; |
There was a problem hiding this comment.
When one user visits /files, signs out, and another user signs in without a document reload, this key still identifies the first user's cached page because it contains only "files", "me", and the table parameters. The browser QueryClient is long-lived, the auth actions invalidate only the session query, ensureQueryData can reuse existing data, and the configured refetchOnMount: false prevents the component from correcting it, so the second user can be shown the first user's file names, metadata, and URLs. Include the user ID in this key or remove this query family whenever authentication changes.
Useful? React with 👍 / 👎.
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?