fix: restore missing circuit-breaker closing brace and threshold read from bad merge - #850
Open
adelekevictor12 wants to merge 4 commits into
Open
Conversation
… from bad merge 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Member
❌ CI Failed —
|
Author
|
ok |
Resolve merge conflicts with latest upstream main: - lib.rs: take upstream's whitespace-clean circuit-breaker code (fix already merged upstream) - test_issues_778_779_781_782.rs: keep .unwrap() variants matching Result-returning fee views - tests/staking_reward_claim.rs: drop obsolete 2-arg API test deleted upstream Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
The branch's copy of the test file used the old client API (initialize, with_mut, .unwrap() on auto-unwrapped client returns) that no longer compiles against the merged lib.rs. Take upstream's version adapted to the current entrypoints (set_protocol_admin/set_treasury_address/ set_key_price, ledger get/set, direct client values). Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
Author
|
@Chucks1093 done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #835