feat: wire remaining dialogs to useModalA11y and unify zh agent terminology - #114
Merged
Merged
Conversation
…nology - CreateAgentDialog / ConnectAgentModal: shared useModalA11y (Escape with acting guard, focus trap, focus return); add aria-modal, drop the hand-rolled Escape listener in ConnectAgentModal. - zh messages: unify agent/Agents/Agent as 智能体 across UI copy (~93 strings); keep technical terms (agent id, AgentPlanet) and code identifiers untouched; tighten CJK spacing around the replacement. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateAgentDialog/ConnectAgentModal接入共享useModalA11y(Escape 关闭、焦点陷阱、焦点归还),与全库其他 dialog 对齐;CreateAgentDialog补aria-modal,Escape 在创建提交中(acting)被守卫;ConnectAgentModal删除自写的 Escape 监听器。agent id/AgentPlanet与所有 key 名不动;收紧替换后中文与「智能体」之间的多余空格。已知不处理项(供 review 参考)
Test plan
packages/agent-chat包级 tsc 通过npm run typecheck通过