Skip to content

refactor(auth): remove context grant authority - #24

Merged
tjtanjin merged 1 commit into
mainfrom
refactor/remove-context-grants
Aug 2, 2026
Merged

tjtanjin merged 1 commit into
mainfrom
refactor/remove-context-grants

Conversation

@halfofning

@halfofning halfofning commented Aug 2, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Remove context-grant fields from Agent, Workflow, schedule, webhook, token, and persistence contracts.
  • Make assigned native tools the routing authority and add deterministic capability-route resolution.
  • Keep ordinary Agent metadata updates from revalidating untouched runtime-managed MCP identifiers.

Cross-Repo Change Set

Tracking issue: none

Related PRs:

Merge order:

  1. control-plane
  2. docs-website
  3. llm-gateway
  4. management-console

Validation

  • Full test run: 1,097/1,098 passed; the sole failure used the pre-fix Agent-conversation readiness mock.
  • Focused Agent-conversation suite after the mock fix: 4/4 passed.
  • Style, migrations, authorization, membership, run-event durability, contracts, OpenAPI, and harness checks passed.
  • TypeScript typecheck passed; a clean emit to /tmp passed. The repository dist directory contains permission-mismatched generated files, so the in-place emit could not overwrite them.
  • Workspace platform-contract validation could not start because test/fixtures/workflow-template-conformance.json is absent from the local control-plane checkout.

Docs Impact

  • Updates contract manifests, security guidance, external-integration documentation, and completed execution plans.

Residual Risk

  • This removes unreleased cross-service fields and must be coordinated with the gateway, console, and documentation PRs.

@tjtanjin
tjtanjin marked this pull request as ready for review August 2, 2026 15:32
@tjtanjin
tjtanjin merged commit 7d47a62 into main Aug 2, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d300b8a9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

name: { type: 'string', minLength: 1, maxLength: 120 },
enabled: { type: 'boolean' },
approvedContextGrants: { type: 'array', items: { type: 'string' } }
enabled: { type: 'boolean' }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove obsolete grants from the webhook description

After this schema removes approvedContextGrants and rejects additional properties, the generated OpenAPI operation description at line 104 still says webhook updates can change “approved grants.” Clients following that description will send a field that both the schema and controller reject, so update the operation text to advertise only the remaining mutable fields.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants