Skip to content

[rule]update to Aria 1.3: ARIA allowed accessibility child roles - #2450

Open
shunguoy wants to merge 6 commits into
developfrom
aria1.3-allowed-child
Open

[rule]update to Aria 1.3: ARIA allowed accessibility child roles#2450
shunguoy wants to merge 6 commits into
developfrom
aria1.3-allowed-child

Conversation

@shunguoy

@shunguoy shunguoy commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

<< Describe the changes >>

Closes issue(s):

Need for Call for Review:
<< choose one of the following and remove the rest >>
<< check Process Document on Call for Review >>
This can be merged with 1 approval << choose reason: editorial changes to website/test code, adding new contributor, other (explain). >>

This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of examples, if in doubt, use this. >>


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@shunguoy shunguoy self-assigned this Sep 3, 2026
@netlify

netlify Bot commented Sep 3, 2026

Copy link
Copy Markdown

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 42e4d4e
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6a997e17560b7f00081d72df
😎 Deploy Preview https://deploy-preview-2450--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@shunguoy shunguoy changed the title [rule]update the to aria 1.3: ARIA allowed accessibility child roles [rule]update to Aria 1.3: ARIA allowed accessibility child roles Sep 3, 2026
Comment thread _rules/aria-required-owned-element-bc4a75.md Outdated
rule_type: atomic
description: |
This rule checks that an element with a semantic role that restricts which elements it can own only owns such elements.
This rule checks that an element with a semantic role contains only children with allowed accessibilility roles.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This rule checks that an element with a semantic role contains only children with allowed accessibilility roles.
This rule checks that an element with a semantic role contains only children with allowed roles.

@dan-tripp-siteimprove dan-tripp-siteimprove Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a nitpick, but I think it matters for readability.

I don't think that the word "accessibility" should be used here. It's redundant. Not pulling it's weight.

In fact, I think it could be removed from a lot of places in this rule, but unfortunately ARIA 1.3 uses the term "accessibility child roles" where "accessibility child" is a term with its own definition. So I'll begrudgingly accept that maybe sometimes we need to say "accessibility child role". Though I would prefer just "child role".

But "accessibility role": no, I don't think we should say that. That term would be an invention of our own, and an unnecessary one.

@shunguoy shunguoy Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually gave this a thought: not all roles are considered as "accessibility roles". For example, 'generic' role is not considered as an accessibility role in a hierarchy structure. Given this, I am fine with removing "accessibility" here to avoid the term confusion.

rule_type: atomic
description: |
This rule checks that an element with a semantic role that restricts which elements it can own only owns such elements.
This rule checks that an element with a semantic role contains only children with allowed accessibilility roles.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This rule checks that an element with a semantic role contains only children with allowed accessibilility roles.
This rule checks that an element with a semantic role contains only children with allowed roles.

Comment thread _rules/aria-required-owned-element-bc4a75.md Outdated
Comment thread _rules/aria-required-owned-element-bc4a75.md Outdated
Comment thread _rules/aria-required-owned-element-bc4a75.md Outdated

#### Passed Example 13

The both `div` elements with explicit `list` roles have no accessible children. The `listitem` element is either with `aria-hidden` or has no owned element through `aira-own` in the first `div` element.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The both `div` elements with explicit `list` roles have no accessible children. The `listitem` element is either with `aria-hidden` or has no owned element through `aira-own` in the first `div` element.
The both `div` elements with explicit `list` roles have no accessible children. Each `listitem` element either has `aria-hidden` or has no owned element through `aria-owns` in the first `div` element.

Comment thread _rules/aria-required-owned-element-bc4a75.md Outdated
shunguoy and others added 5 commits September 3, 2026 08:56
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
@shunguoy
shunguoy marked this pull request as ready for review September 3, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants