[rule]update to Aria 1.3: ARIA allowed accessibility child roles - #2450
[rule]update to Aria 1.3: ARIA allowed accessibility child roles#2450shunguoy wants to merge 6 commits into
Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| rule_type: atomic | ||
| description: | | ||
| This rule checks that an element with a semantic role that restricts which elements it can own only owns such elements. | ||
| This rule checks that an element with a semantic role contains only children with allowed accessibilility roles. |
There was a problem hiding this comment.
| This rule checks that an element with a semantic role contains only children with allowed accessibilility roles. | |
| This rule checks that an element with a semantic role contains only children with allowed roles. |
There was a problem hiding this comment.
Maybe this is a nitpick, but I think it matters for readability.
I don't think that the word "accessibility" should be used here. It's redundant. Not pulling it's weight.
In fact, I think it could be removed from a lot of places in this rule, but unfortunately ARIA 1.3 uses the term "accessibility child roles" where "accessibility child" is a term with its own definition. So I'll begrudgingly accept that maybe sometimes we need to say "accessibility child role". Though I would prefer just "child role".
But "accessibility role": no, I don't think we should say that. That term would be an invention of our own, and an unnecessary one.
There was a problem hiding this comment.
I actually gave this a thought: not all roles are considered as "accessibility roles". For example, 'generic' role is not considered as an accessibility role in a hierarchy structure. Given this, I am fine with removing "accessibility" here to avoid the term confusion.
| rule_type: atomic | ||
| description: | | ||
| This rule checks that an element with a semantic role that restricts which elements it can own only owns such elements. | ||
| This rule checks that an element with a semantic role contains only children with allowed accessibilility roles. |
There was a problem hiding this comment.
| This rule checks that an element with a semantic role contains only children with allowed accessibilility roles. | |
| This rule checks that an element with a semantic role contains only children with allowed roles. |
|
|
||
| #### Passed Example 13 | ||
|
|
||
| The both `div` elements with explicit `list` roles have no accessible children. The `listitem` element is either with `aria-hidden` or has no owned element through `aira-own` in the first `div` element. |
There was a problem hiding this comment.
| The both `div` elements with explicit `list` roles have no accessible children. The `listitem` element is either with `aria-hidden` or has no owned element through `aira-own` in the first `div` element. | |
| The both `div` elements with explicit `list` roles have no accessible children. Each `listitem` element either has `aria-hidden` or has no owned element through `aria-owns` in the first `div` element. |
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
<< Describe the changes >>
Closes issue(s):
[bc4a75] Update the rule and examples to comply with ARIA1.3 #2438
Need for Call for Review:
<< choose one of the following and remove the rest >>
<< check Process Document on Call for Review >>
This can be merged with 1 approval << choose reason: editorial changes to website/test code, adding new contributor, other (explain). >>
This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of examples, if in doubt, use this. >>
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve