Skip to content

Use @tsconfig/node16 instead of custom tsconfig.json - #651

Closed
JamieMagee wants to merge 1 commit into
actions:mainfrom
JamieMagee:tsconfig-node16
Closed

Use @tsconfig/node16 instead of custom tsconfig.json#651
JamieMagee wants to merge 1 commit into
actions:mainfrom
JamieMagee:tsconfig-node16

Conversation

@JamieMagee

@JamieMagee JamieMagee commented Apr 17, 2023

Copy link
Copy Markdown

Description:
Use @tsconfig/node16 instead of a custom tsconfig.json. Equivalent to:

{
  "$schema": "https://json.schemastore.org/tsconfig",
  "display": "Node 16",

  "compilerOptions": {
    "lib": ["es2021"],
    "module": "commonjs",
    "target": "es2021",

    "strict": true,
    "esModuleInterop": true,
    "skipLibCheck": true,
    "forceConsistentCasingInFileNames": true,
    "moduleResolution": "node"
  }
}

Also required an updated version of TypeScript, to recognise ES2021 as a valid target, and updated version of ncc to recognise the updated TypeScript.

Related issue:
N/A

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@JamieMagee
JamieMagee requested a review from a team as a code owner April 17, 2023 00:17
@gowridurgad

Copy link
Copy Markdown
Contributor

Hi @JamieMagee, thanks for the PR. At the time this was opened, this change made sense. Since then, the repository has moved to an ESM/NodeNext setup and the TypeScript/tooling configuration has changed quite a bit. Because of that, this PR no longer applies cleanly to the current project structure, and the related dependency and generated dist updates are now out of date as well. We’re going to close this out, but thank you again for the contribution.

@gowridurgad gowridurgad closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants