feat: asa max conversions and loc invoicing flags - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
NOT_RUNNINGwithAUTOMATED_KEYWORDS_REQUIRED_AD_GROUP_MISSING: Apple requires an automated ad group (automatedKeywordsRequired=true, nostart_time), and the CLI could neither send that field nor omit the default start time.payment_model: LOC) must fill Invoicing Options on every campaign, otherwise Apple parks it withMISSING_BO_OR_INVOICING_FIELDS. The CLI had no way to passloc_invoice_details.serving_status/serving_state_reasons, so users only saw "not spending".Backend contract:
feature/ASA-767-cli-mc-locin asa-analytics (not deployed yet).What
asa ad-groups create --automated— sendsautomated_keywords_required: true,automated_keywords_opt_in: true, nostart_time, nodefault_bid_amountunless--default-bidis given.--default-bidis now required only without--automated;--automated --start-timeexits 2 before the network.asa campaigns create|update— five Invoicing Options flags (--invoice-advertiser,--invoice-order-number,--invoice-contact-name,--invoice-contact-email,--invoice-billing-email) →loc_invoice_details. All five or none; a partial set exits 2 before the network.NOT_RUNNING+serving_state_reasonsare printed with the fixing command for the two reasons above (stdout only,--jsonstays a clean result).serving_status,serving_state_reasons,payment_model,loc_invoice_details,automated_keywords_requiredon the matching DTOs.docs/agent/asa-management.md, skill references, README): Max Conversions and Line of credit sections,payment_modelonasa orgs list.Checks
pnpm build,eslint src test— cleanmocha— 174 passing (5 new tests inasa-writes.test.ts)node scripts/check-agent-docs.mjs— docs match the manifest