feat: require explicit metrics and add scope flags - #22
Open
adressop6789-max wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with asa-analytics!1584, which makes
metricsrequired onPOST /cli/metrics/.Why the backend changed:
subscribersandpaid_subscribersare exact-uniqueness aggregations over profile ids, one hash set per entity per renewal window. On a keyword list that measured 11.4 GB against 0.13 GB for the same page without them, and production ClickHouse killed 17 queries on it. Omitting--metricused to mean "every column", which is how a paginated keyword export became the most expensive query on the cluster.--metricis now required, and its help says why a short list matters.--app,--campaign,--ad-groupscope filters go into the request body asapp_id/campaign_id/ad_group_id. They are what unlockssubscriberson--entity keyword(the backend refuses those metrics account-wide with422 cli_metric_scope_too_wide), and the cheapest way to make any keyword call fast.Ship to npm together with the backend: a client without
--metricgets 422 after that deploy.tsc -bclean, 174 mocha tests passing.