feat(evaluators): add AgentControl support for Orbit preset SLM scorer invocation - #259
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
abhinav-galileo
left a comment
There was a problem hiding this comment.
[P1][pre-existing] Make cached async clients event-loop-safe
Cached evaluator instances retain pooled httpx.AsyncClient objects, while the synchronous decorator creates a new event loop per call. Reusing a keep-alive connection on a later loop can fail with RuntimeError: Event loop is closed, and cache eviction does not close these clients. This predates this PR and is not a regression introduced here; please track loop-scoped ownership or a persistent-loop lifecycle with awaited cleanup separately.
|
@abhinav-galileo Review follow-up for
The dependency-floor, invocation-resolved ADK tools, forward-compatible config, and deep |
|
@abhinav-galileo Follow-up on the four remaining review threads:
|
1 similar comment
|
@abhinav-galileo Follow-up on the four remaining review threads:
|
Summary
scorer_id;scorer_labelis optional display metadata andscorer_version_idis a deprecated compatibility identifier./api/v1/scorers/invokewith a scoped internal HS256 JWT (scorers.invoke).inputsand a structuredrecordduring the rollout, including selector-aligned input/output plus Step context, tools, and ground truth.Scope
Risk and Rollout
inputs.query/inputs.responsecontract if needed.Testing
git diff --checklocalhost:5432Follow-up
Orbit #1720 must update all six AgentControl git references to commit
8a2b5d52717090ed7c65b627035f73d89c46f5ffand regenerate requirements before the tandem merge.