chore(deps): bump torch from 2.13.0 to 2.14.0 - #102
Conversation
Bumps [torch](https://github.com/pytorch/pytorch) from 2.13.0 to 2.14.0. - [Release notes](https://github.com/pytorch/pytorch/releases) - [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md) - [Commits](pytorch/pytorch@v2.13.0...v2.14.0) --- updated-dependencies: - dependency-name: torch dependency-version: 2.14.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
imran-siddique
left a comment
There was a problem hiding this comment.
Reviewed ad94509.
The existing CI and Smoke runs pass, but neither installs requirements-lora.txt. The WCM job installs requirements.txt and runs offline demos, so those green checks do not validate torch 2.14.0 with the pinned Transformers, PEFT and Accelerate versions. Holding approval until the complete LoRA requirements resolve and an offline adapter creation/save/load smoke test runs against this pin. This is a coverage gap, not an observed PyTorch regression.
imran-siddique
left a comment
There was a problem hiding this comment.
Reviewed ad94509.
Closed the coverage gap from my previous review with an isolated installation of the exact LoRA requirements: torch 2.14.0, huggingface_hub 1.29.0, Transformers 5.16.1, PEFT 0.20.0, Accelerate 1.14.0, safetensors 0.8.0 and model-signing 1.1.1. Using a locally generated tiny Llama model/tokenizer with Hub access disabled, exercised the PR's real_lora_custody.train_lora for two gradient steps, confirmed nonzero learned LoRA B weights, encrypted/decrypted the saved adapter with inventory verification, rejected a wrong key, then reloaded through run_inference successfully. This is an offline compatibility test, not a hosted model download or GPU benchmark. Existing hosted CI also passes apart from the review gate.
Bumps torch from 2.13.0 to 2.14.0.
Release notes
Sourced from torch's releases.
... (truncated)
Commits
2b3ec34[release/2.14] Import SDPAParams in test_transformers to fix lint (#194970)08187d9[cuDNN] Add guards for cuDNN SDPA decode (#194963)8ceea97Pin cython < 3.3.0 for the Windows Triton wheel build (#194931)99ecebc[Cherry-pick][release/2.14] [inductor] Fix loop-local load CSE lifetime (#194...ec283a7Bump the Python 3.15 numpy pin to 2.5.2 (#194821)65890f3Fix docker-release validate job to use the channel matching the pushed image ...1682388Fix macOS py3.15 wheel builds: pin Cython < 3.3.0 and bump the cp315 numpy pi...9724418Fix Windows py3.15 builds: constrain Cython < 3.3.0 and bump the cp315 numpy ...f1b7554[MPS] Fix pin_memory() recycling buffers still in use by the GPU (#194662)9f205f7[MPS] fail loudly on large reductions (#194661)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)