ci: add actionlint - #97
Merged
Merged
Conversation
A duplicate env: key in a sibling repo's release.yml made GitHub refuse to load the workflow. It surfaced as a "workflow file issue" on unrelated pushes, the release event ran nothing, and a version sat unpublished for hours. yaml.safe_load keeps the last value for a duplicate key without complaining, so local validation passed. actionlint reports it directly. Fetched by pinned version and checksum-verified rather than run as a third-party action, so a check that exists to guard the workflow supply chain does not add to it. Runs only when .github/workflows changes, and this repo is clean against it today. No test-environment guard here: this repo tests against third-party distributions on purpose, so there is no package of its own to shadow. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbDBXDWWvMFa7c2jGgyq9t
actionlint runs shellcheck over run: blocks on the CI runners, which my local Windows run could not, so these only appeared once the check was in CI. All six across the org are genuine; none was a false positive. SC2086, unquoted expansion in the cosign step: a digest is word-split before cosign sees it. Quoted. SC2162, read without -r in the file-validation loops: a backslash in a path is mangled rather than passed through. SC2155, export with command substitution in the keygen step: export masks the command's exit status, so an openssl failure produced an empty key and carried on. Declared and exported separately, so set -e can see the failure. SC2129, four separate appends to $GITHUB_STEP_SUMMARY: one redirection block instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbDBXDWWvMFa7c2jGgyq9t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A duplicate
env:key in a sibling repo'srelease.ymlmade GitHub Actions refuse to load the workflow. It surfaced as a "workflow file issue" on unrelated pushes, the release event ran nothing, and a version sat unpublished for hours.It got through because
yaml.safe_loadkeeps the last value for a duplicate key without complaining. actionlint says it plainly:Verified against a reproduction of the exact broken file before adding it.
On how it's installed: fetched by pinned version with a checksum verification, not run as a third-party action. actionlint publishes no official action, and a check whose purpose is guarding the workflow supply chain should not add a new dependency to it.
Triggered only on changes under
.github/workflows, so it costs nothing on ordinary PRs. This repo is clean against it today, so it adds no backlog.The sibling PRs also carry a pytest guard against a suite silently grading an installed wheel instead of the tree. This repo tests against third-party distributions on purpose and has no package of its own to shadow, so it gets actionlint only.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XbDBXDWWvMFa7c2jGgyq9t