chore: require aleph-message 1.3.0 for V-PROGRAM support - #291
Conversation
aleph-message 1.3.0 adds MessageType.v_program and VerifiableProgramMessage. Bump the floor so listing and fetching V-PROGRAM messages is guaranteed to parse, and cover it with unit tests.
foxpatch-aleph
left a comment
There was a problem hiding this comment.
A clean, minimal PR that bumps the aleph-message floor from >=1.1.1 to >=1.3.0 to gain V-PROGRAM support (MessageType.v_program, VerifiableProgramMessage, registers.launch measurement shape). No SDK code changes are needed since read-side parsing goes through aleph_message.parse_message. The three new tests cover listing V-PROGRAM messages, fetching a single V-PROGRAM message by hash with type validation, and HTTP param serialization for the msgTypes filter — all following existing test patterns (make_mock_get_session, async with, MessageFilter). The mock V-PROGRAM message payload includes all required fields and uses ignore_invalid_messages=False to ensure the fixture actually parses. No correctness, security, or quality concerns.
|
Failed to retrieve llama text: POST 502: Bad Gateway |
foxpatch-aleph
left a comment
There was a problem hiding this comment.
This PR correctly bumps the aleph-message dependency floor from >=1.1.1 to >=1.3 (equivalent to >=1.3.0 per PEP 440) to enable V-PROGRAM message support via MessageType.v_program, VerifiableProgramMessage, and the registers.launch measurement shape. No SDK code changes are needed since read-side parsing goes through aleph_message.parse_message. The three new tests are well-structured and cover listing V-PROGRAM messages, fetching a single V-PROGRAM message, and the msgTypes=V-PROGRAM HTTP filter parameter serialization. The mock data includes all required V-PROGRAM fields with a realistic SEV-SNP verification configuration. All new tests pass, and pre-existing failures in the suite are unrelated (missing optional secp256k1 dependency).
Summary
aleph-messagefloor from>=1.1.1to>=1.3.0. 1.3.0 addsMessageType.v_program,VerifiableProgramMessageand theregisters.launchmeasurement shape; without it,MessageType.v_programis anAttributeErrorand V-PROGRAM messages fail to parse inget_messages/get_message/watch_messages.msgTypes=V-PROGRAMfilter parameter.No SDK code changes are needed for read-side support: everything goes through
aleph_message.parse_message.Test plan
pytest tests/unitwith aleph-message 1.3.0 (238 passed)get_messages(MessageFilter(message_types=[MessageType.v_program]))against api2/api3 (0 results today, parses fine)🤖 Generated with Claude Code
https://claude.ai/code/session_018hGRkZE1a3i19yrf2uBasD