fix(@angular/build): prevent syntax corruption in oxc transform [22.1.x] - #33792
Merged
alan-agius4 merged 3 commits intoAug 6, 2026
Merged
Conversation
Preserve parentheses when unwrapping enum IIFE argument assignments so expressions like Area || (exports.Area = {}) maintain correct operator precedence.
(cherry picked from commit 1e9f7c0)
…t check (cherry picked from commit 3a79292)
…um IIFE When transforming Crockford-style TypeScript enum IIFEs, ensure all leading and trailing parentheses of the expression statement are removed when moving the IIFE call expression to the var initializer. Fixes angular#33785 (cherry picked from commit e7124ef86ae9443cfa15fbb122be586b51eb1b0a)
alan-agius4
added
action: review
1 task
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the oxc-transform Babel plugin to correctly handle and clean up TypeScript enums wrapped in parentheses or containing chained export assignments, preventing dangling parentheses. It also adds comprehensive test cases to verify these scenarios. The feedback suggests checking if the right-hand side argument is already parenthesized before wrapping it in parentheses to avoid redundant double parentheses.
clydin
approved these changes
Aug 6, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of oxc transform syntax corruption fixes for
22.1.x:1e9f7c0e39d295a2757802abdb918e07b46ce244, excluding linker changes).unwrapParenthesesfor oxc AST assignment check (cherry picked from commit3a79292b2d75f924b3f9d91ad9a26287c3f206d5).e7124ef86ae9443cfa15fbb122be586b51eb1b0a).Fixes #33785