Skip to content

fix(audit): merge ruleset required checks when legacy list is empty #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rockygeekz wants to merge 1 commit into from
Closed

fix(audit): merge ruleset required checks when legacy list is empty #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .agents/skills/td-supply-chain-audit/scripts/collect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1338,7 +1338,16 @@ def collect_branch_protection(repo: str) -> dict:
endpoint = f"repos/{repo}/branches/main/protection"
data = gh_api(endpoint)
if data and isinstance(data, dict) and "message" not in data:
return _legacy_branch_protection_result(data)
result = _legacy_branch_protection_result(data)
# Legacy API often returns empty required_status_checks.checks when the
# repo moved checks to rulesets (e.g. ansible/actions). Merge rulesets
# so audits do not false-positive "no required status checks".
if not result["required_checks"]:
ruleset_checks = _collect_ruleset_required_checks(repo)
if ruleset_checks:
result["required_checks"] = ruleset_checks
result["source"] = "branch_protection+rulesets"
return result

required_checks = _collect_ruleset_required_checks(repo)
if not required_checks:
Expand Down
Loading