Conversation
Author
|
This PR also addresses the issues described in #19, particularly the missing SYNOP Section 5 supplementary groups and the inconsistent handling of the 910 gust group. The relevant decoding and encoding support has been added along with regression tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves SYNOP decoding and encoding, with a focus on Sections 5, 6 and 7.
Changes
3ddffand4ddff).99).Code Table 0877
The wind direction encoder previously did not correctly preserve the SYNOP
99value for variable/unknown wind direction.This change ensures that:
is decoded and encoded consistently.
Testing
The full test suite passes successfully:
The warnings are existing
DecodeWarningmessages related to SYNOP Group 7 handling and do not cause test failures.Also verified SYNOP round-trip encoding/decoding for:
00000)13612)19906)All tested cases round-trip successfully.