Add memory used to scan trace spans - #6524
Open
DomGarguilo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6022
table.scan.max.memoryis checked againstKVEntry.estimateMemoryUsed()(which is the bytes + 288 bytes per entry overhead for the java object), butaccumulo.scan.bytes.returnedreports bytes only. Meaning a stopped batch will report lower than actual. For example a batch that stopped at 1M will report ~820k making it seem like the config was ignored.This PR adds
accumulo.scan.memory.usedwith the value the limit actually uses which clarifies the property description and helps outline the difference.