AMBARI-26591: Remove unused form2js dependency from WF Manager UI - #4116
AMBARI-26591: Remove unused form2js dependency from WF Manager UI#4116dilrajsourabh wants to merge 2 commits into
Conversation
…sed by wildcard dependency resolution
|
@iRakson , can you please help in reviewing and merging this changes. |
|
Oh, my bad. I revived it around February and moved the old version to the 'legacy' branch. I honestly didn't expect anyone to still depend on the repo like that. I checked the Ambari codebase though, and it looks like form2js isn't actually used anywhere besides being imported. So rather than pinning it to v2.0, I think the better fix would be to remove the dependency and the import entirely. |
form2js was only imported and never used in the codebase; removing it avoids the broken upstream dependency entirely.
|
Hi @maxatwork ,thanks for the clarification, and for checking the codebase. You're right — form2js was only listed in bower.json and imported in ember-cli-build.js, with no actual usage anywhere in the WF Manager UI. I've updated the PR accordingly:
This should fully address the build failure without depending on the upstream repo at all. The change is pushed in commit 8c31f68. Could you please merge this when you get a chance? Thanks again for the review. |
|
You're welcome! Sorry, but I can't merge it - I'm not a maintainer of Ambari, I'm just the author of form2js 😅 |
What changes were proposed in this pull request?
This PR pins the form2js dependency to a fixed version (maxatwork/form2js#v2.0) in contrib/views/wfmanager/src/main/resources/ui/bower.json.
Previously, "form2js": "*" resolved to the latest tag, which recently changed and no longer contains the expected src/form2js.js structure required by Ambari.
Pinning the version restores the expected folder layout and prevents the ENOENT build failure.
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.