Skip to content

AMBARI-26591: Remove unused form2js dependency from WF Manager UI - #4116

Open
dilrajsourabh wants to merge 2 commits into
apache:trunkfrom
dilrajsourabh:AMBARI-26591
Open

AMBARI-26591: Remove unused form2js dependency from WF Manager UI#4116
dilrajsourabh wants to merge 2 commits into
apache:trunkfrom
dilrajsourabh:AMBARI-26591

Conversation

@dilrajsourabh

Copy link
Copy Markdown

What changes were proposed in this pull request?

This PR pins the form2js dependency to a fixed version (maxatwork/form2js#v2.0) in contrib/views/wfmanager/src/main/resources/ui/bower.json.
Previously, "form2js": "*" resolved to the latest tag, which recently changed and no longer contains the expected src/form2js.js structure required by Ambari.
Pinning the version restores the expected folder layout and prevents the ENOENT build failure.

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@Sourabh-Dilraj

Copy link
Copy Markdown

@iRakson , can you please help in reviewing and merging this changes.

@maxatwork

Copy link
Copy Markdown

Oh, my bad. I revived it around February and moved the old version to the 'legacy' branch. I honestly didn't expect anyone to still depend on the repo like that.

I checked the Ambari codebase though, and it looks like form2js isn't actually used anywhere besides being imported. So rather than pinning it to v2.0, I think the better fix would be to remove the dependency and the import entirely.

form2js was only imported and never used in the codebase; removing it avoids the broken upstream dependency entirely.
@dilrajsourabh

Copy link
Copy Markdown
Author

Hi @maxatwork ,thanks for the clarification, and for checking the codebase.

You're right — form2js was only listed in bower.json and imported in ember-cli-build.js, with no actual usage anywhere in the WF Manager UI. I've updated the PR accordingly:

  • Removed the form2js dependency from bower.json

  • Removed the unused import from ember-cli-build.js

This should fully address the build failure without depending on the upstream repo at all. The change is pushed in commit 8c31f68.

Could you please merge this when you get a chance? Thanks again for the review.

@dilrajsourabh dilrajsourabh changed the title AMBARI-26591: Pin form2js to v2.0 to fix WF Manager build failure caused by wildcard dependency resolution AMBARI-26591: Remove unused form2js dependency from WF Manager UI Aug 23, 2026
@maxatwork

Copy link
Copy Markdown

You're welcome! Sorry, but I can't merge it - I'm not a maintainer of Ambari, I'm just the author of form2js 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants