Skip to content

[Hotfix] Remove slf4j classes from kyuubi-hive-jdbc-shaded - #4342

Open
zhoujinsong wants to merge 1 commit into
apache:masterfrom
zhoujinsong:fix-ams-logger
Open

[Hotfix] Remove slf4j classes from kyuubi-hive-jdbc-shaded#4342
zhoujinsong wants to merge 1 commit into
apache:masterfrom
zhoujinsong:fix-ams-logger

Conversation

@zhoujinsong

Copy link
Copy Markdown
Contributor

Why are the changes needed?

kyuubi-hive-jdbc-shaded shade the slf4j 1.x classes which are conflicts with slf4j 2.x in ams.
This PR removed them from the jar to avoid conflicts.

Brief change log

  • As title

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@j1wonpark

Copy link
Copy Markdown
Contributor

Reproduced with the 0.9.0 RC5 binary and on our k8s deployment. AMS and optimizer logs are empty (StaticLoggerBinder NOP fallback). Putting slf4j-api first on the classpath brings them back, so the fix looks right. RC5 doesn't include this, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants