Skip to content

[AMORO-4343][ams] Fix runtime creation for unsupported table formats - #4344

Open
csurong wants to merge 1 commit into
apache:masterfrom
csurong:fix/unsupported-format-runtime
Open

[AMORO-4343][ams] Fix runtime creation for unsupported table formats#4344
csurong wants to merge 1 commit into
apache:masterfrom
csurong:fix/unsupported-format-runtime

Conversation

@csurong

@csurong csurong commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Why are the changes needed?

Close #4343.

External catalog synchronization invokes triggerTableAdded for every discovered table. When a table format has catalog support but no available TableRuntimeCreator, persisting table_runtime leaves a database-only runtime row. A later scan attempts to insert the same table_id again and logs a duplicate primary key error.

Brief change log

  • Check TableRuntimeFactory support before persisting table runtime metadata.
  • Add a Paimon integration test that verifies metadata synchronization succeeds, no runtime is created, and repeated scans remain safe.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible
  • Add screenshots for manual tests if appropriate
  • Run test locally before making a pull request

Commands:

  • ./mvnw -q -pl amoro-ams -am -Pskip-dashboard-build -Dtest=TestSyncUnsupportedTableFormat -DfailIfNoTests=false test
  • ./mvnw -q -pl amoro-ams -am -Pskip-dashboard-build -Dtest=TestSyncTableOfExternalCatalog,TestSyncUnsupportedTableFormat -DfailIfNoTests=false test
  • ./mvnw -q -pl amoro-ams -am -Pskip-dashboard-build -DskipTests spotless:check

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@github-actions github-actions Bot added the module:ams-server Ams server module label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Table explorer creates runtimes for unsupported table formats

1 participant