chore(arrow-flight-sql): remove register_sql_info from FlightSqlService - #10904
Open
mnpw wants to merge 1 commit into
Open
chore(arrow-flight-sql): remove register_sql_info from FlightSqlService#10904mnpw wants to merge 1 commit into
mnpw wants to merge 1 commit into
Conversation
Rich-T-kid
suggested changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
FlightSqlService::register_sql_infoappears to be stale artefact and it is effectively a no-op in the trait definition. It appears to be carried over from Go'sBaseServerimplementation.Since
FlightSqlServiceintends to represent Go'sServerimplementation instead it makes sense to remove this method fromFlightSqlService.Note: An alternative to removal of this method is change in its signature to
FlightSqlService::register_sql_info(id: SqlInfo, result: SqlInfoValue). I can implement that instead as well but it deviates from whatFlightSqlServicetrait should be doing.What changes are included in this PR?
Remove
register_sql_infofromFlightSqlServiceAre these changes tested?
Tested via -
Are there any user-facing changes?
Yes. This removes a public trait method. Implementors that currently define
register_sql_infoas part of theirFlightSqlServiceimplementation must remove it.