feature: introduce type check ci job - #10960
Open
Rich-T-kid wants to merge 7 commits into
Open
Conversation
Rich-T-kid
commented
Sep 2, 2026
| @@ -0,0 +1,69 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
Author
There was a problem hiding this comment.
this script and the ci job are pretty much just copied from datafusion. it doesnt look like theres any reason to change it but I may be wrong
Contributor
Author
|
should I fix the spelling errors in this PR or in a separate one? any thoughts @Jefffrey |
Contributor
|
ideally this one, but a lot of them seem to be false positives |
github-actions
Bot
added
parquet
github-actions
Bot
added
arrow-flight
Contributor
Author
true, tried to trim them down as much as possible. at least now PR's wont be able to have vague 1/2 letter variable names 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
see #10943 (comment)
What changes are included in this PR?
add
.github/ci/scripts/typos_check.sh& typo's job to the CIAre these changes tested?
not sure how to test this
Are there any user-facing changes?
yes, users PR's will show a ci failure if they have typos in comments