ATLAS-5384: Atlas Classic UI: Upgrade UI dependencies for dashboardv2 - #736
Open
Brijesh619 wants to merge 1 commit into
Open
ATLAS-5384: Atlas Classic UI: Upgrade UI dependencies for dashboardv2#736Brijesh619 wants to merge 1 commit into
Brijesh619 wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What changes were proposed in this pull request?
The legacy
dashboardv2module requires dependency upgrades to address outdated sub-packages and close open Dependabot pull requests. Becausedashboardv2is tied to the older npm v6 build environment via Maven, attempting to upgrade deeply nested sub-dependencies using manualresolutionsoroverridesis unsupported.This PR cleanly resolves the outdated dependencies and vulnerabilities by natively upgrading their top-level parent build tools in
package.jsonto exact pinned versions.Changes include:
gruntto1.6.3(Inherently pulls in a modernized version ofmicromatchto resolvepicomatchvulnerabilities - PR Bump picomatch from 2.3.1 to 2.3.2 in /dashboardv2/public/js/external_lib/atlas-lineage #588 & PR Bump picomatch from 2.3.1 to 2.3.2 in /dashboardv2 #579).grunt-contrib-connectto5.0.1(Inherently pulls in modernized versions ofserve-staticandsendvulnerabilities - PR Bump serve-static from 1.14.1 to 1.16.2 in /dashboardv2 #254 & PR Bump send and serve-static in /dashboardv2 #253).grunt-contrib-cssminto4.0.0(Inherently resolves nestedclean-cssandtrim-newlinesvulnerabilities while retaining strict Node 12 compatibility).overridesblocks frompackage.jsonto rely entirely on native, safe npm dependency resolution.package-lock.json(lockfileVersion: 1) using the strictly enforced Node v12.16.0 / npm v6.13.7 environment.How was this patch tested?
node_modulesand rannpm installinsidedashboardv2using the project-mandated Node v12.16.0 and npm v6.13.7 binaries to guarantee lockfile compatibility.npm auditto confirm that thepicomatch,serve-static,send,clean-css, andtrim-newlinesvulnerabilities are completely eliminated from the dependency tree.mvn clean -DskipTests -Drat.skip=false package -Pdist,embedded-hbase-solrfrom the root directory.