Skip to content

UI: fix cannot update physical network - #13810

Open
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:4.23-ui-fix-update-physical-network
Open

UI: fix cannot update physical network#13810
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:4.23-ui-fix-update-physical-network

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes #13804

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the UI action configuration for Physical Networks to fix the “Update Physical Network” dialog rendering issue described in #13804, aligning the UI’s editable fields with the actual updatePhysicalNetwork API parameters.

Changes:

  • Removes the unsupported externaldetails argument from the Physical Network “update” action to prevent the autogenerated form from including an invalid/undefined field.
  • Keeps the update dialog focused on supported editable fields (vlan, tags).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (4f11707) to head (f4d40a2).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13810      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
+ Complexity    19792    19790       -2     
============================================
  Files          6368     6368              
  Lines        574881   574881              
  Branches      70351    70351              
============================================
- Hits         112970   112963       -7     
- Misses       449639   449647       +8     
+ Partials      12272    12271       -1     
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@weizhouapache weizhouapache added this to the 4.23.0 milestone Aug 6, 2026
@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13810 (QA-JID-972)

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VLAN/VNI field not populated in GUI / Can't modify physical network

5 participants