YARN-11985: Placement rule does not allow to select Leaf Queue as Parent although Dynamic Queue Creation is turned on - #8686
Open
susheelgupta7 wants to merge 4 commits into
Open
Conversation
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
changed the title
slfan1989
reviewed
Aug 15, 2026
slfan1989
left a comment
slfan1989
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on YARN-11985. The overall approach makes sense and allows queues with Dynamic Queue Creation enabled to be selected as placement-rule parents even when they do not currently have child queues.
I found one issue where the live autoCreationEligibility takes precedence over a staged disable, which can leave an invalid queue in the parent dropdown. Please address the inline comment and add focused unit tests for live legacy/flexible eligibility, staged enable, and staged disable.
| eligibility === AUTO_CREATION_PROPS.ELIGIBILITY_FLEXIBLE || | ||
| eligibility === AUTO_CREATION_PROPS.ELIGIBILITY_LEGACY | ||
| ) { | ||
| return true; |
Contributor
There was a problem hiding this comment.
This early return prevents the staged configuration from taking effect. If the queue is currently flexible, but the user stages both auto-creation properties to false, the queue will still be included in the parent queue dropdown.
Could we read both values from getQueuePropertyValue first and let staged values take precedence, falling back to autoCreationEligibility only when neither property has a staged override?
Contributor
Author
There was a problem hiding this comment.
Thanks @slfan1989 for the review. I’ve fixed the precedence issue.
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
Thanks @susheelgupta7 for the fix! FYI, the fix can be also validated with the built in dev server and mock data. LGTM |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…ent although Dynamic Queue Creation is turned on
|
💔 -1 overall
This message was automatically generated. |
susheelgupta7
force-pushed
the
YARN-11985
branch
from
August 24, 2026 13:26
c001898 to
9d9ccaf
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@slfan1989 @brumi1024 The license warning is unrelated change causing the Yetus failure. Could you review this fix again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains content generated by Cursor.
Description of PR
When creating a placement rule in the CS UI, the parent queue dropdown did not show queues that had dynamic queue creation enabled but no static child queues.
Now a queue is considered a parent if it either has child queues or has dynamic queue creation enabled.
How was this patch tested?
Tested manually on the cluster.
For code changes:
declared according to the connector-specific documentation? Note: Automated CI
testing doesn't cover all cases so manual testing with cloud storage is still
required.
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html