feat(storage): zero-copy writes and empty bucket validation for object_store backend - #3167
Closed
Sruhvx-jpg wants to merge 3 commits into
Closed
feat(storage): zero-copy writes and empty bucket validation for object_store backend#3167Sruhvx-jpg wants to merge 3 commits into
Sruhvx-jpg wants to merge 3 commits into
Conversation
…oncurrent deletes - Hoist `object_store` 0.13 to workspace dependencies to align with DataFusion. - Support `s3n://` scheme alongside `s3://` and `s3a://` in `parse_s3_url`. - Optimize `delete_stream` with `try_for_each_concurrent` instead of sequential loop. - Add unit tests for `s3n://` URL parsing and FileIO/Storage serialization roundtrips. - Wire crate workspace lints and publish flag.
Author
|
Closing this PR as these improvements (zero-copy writes and empty bucket validation) have been folded directly into #3165 to keep the review unified and avoid duplicate diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
ObjectStoreWriter::writefromwriter.write(&bs)towriter.put(bs)to pass ownedbytes::Bytesdirectly without copying memory into intermediate buffers.s3:///path/to/fileors3://) withErrorKind::DataInvalid.test_parse_s3_url_empty_bucket.Context
Builds on the foundation introduced in #3165 to resolve #3166.
Are these changes tested?
Yes, all 12 unit tests passing in
crates/storage/object_store(cargo test -p iceberg-storage-object_store).