feat(encryption/kms): Add AWS KMS client - #3173
Open
zakariya-s wants to merge 3 commits into
Open
Conversation
xanderbailey
reviewed
Sep 8, 2026
xanderbailey
reviewed
Sep 8, 2026
Contributor
There was a problem hiding this comment.
I don't know if this should be a whole new crate or just a feature flag, opendal backends we just feature flag WDYT?
Contributor
Author
There was a problem hiding this comment.
Yeah I'm not sure either, I considered both but for opendal the backends all share the same adapter while the KMS implementations wouldn't have the same. Java Iceberg also has separate modules for AWS, etc. Having them in separate crates also keeps SDK deps isolated. I can see three potential ways to organise this:
- Keep it in the core crate and use feature flags
- Have separate crates for iceberg-kms-aws, etc.
- Have one iceberg-kms crate with feature flags for AWS, etc.
I'm happy with any of these approaches honestly
Collaborator
Contributor
Author
It implements the same but the previous PR has been inactive for a few months now. This also addresses some of @xanderbailey's comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
KeyManagementClientfor AWS KMS #2466.What changes are included in this PR?
Adds a new
iceberg-kms-awscrate implementing Iceberg client-side encryption key management with AWS KMS.The KMS client is created once from the application-supplied catalog properties and shared across the catalog, matching the existing
KmsClientFactorylifecycle.Are these changes tested?
Yes.
The AWS SDK mock framework was also used to test AWS calls.
AI Disclosure
LLMs were used to assist, but the code has been validated by hand.