fix(io): bound S3 write request size with a configurable part size - #3179
Open
YuangGao wants to merge 1 commit into
Open
fix(io): bound S3 write request size with a configurable part size#3179YuangGao wants to merge 1 commit into
YuangGao wants to merge 1 commit into
Conversation
YuangGao
marked this pull request as ready for review
September 9, 2026 06:47
anoopj
reviewed
Sep 9, 2026
anoopj
left a comment
Member
There was a problem hiding this comment.
CI check-public-api is failing. This PR changes a couple of public API surfaces that aren't reflected in the checked-in public-api.txt files.
Please run make generate-public-api and commit both updated files.
| config: Arc<S3Config>, | ||
| /// Bytes carried by one multipart upload request. | ||
| #[serde(default = "default_multipart_part_size")] | ||
| multipart_part_size: usize, |
Member
There was a problem hiding this comment.
This field is serialized and is round-tripped. A usize-typed serialized value ties the wire format to host word size. This might cause issues if we have heterogeneous setup (granted, they are rare). Consider storing u64 and converting as usize somewhere in the edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
OpenDAL turns one caller buffer into one request, and
ParquetWriterhands over a whole row group perwritecall. A 128 MiB row group therefore became a singleUploadPartracing the hard-coded 10s IO timeout, and since every retry re-sends the same oversized request, the write fails deterministically rather than flakily.Bound the request size so it follows configuration instead of the caller's buffer:
s3.multipart.part-size-bytes, default 32 MiB (matching JavaS3FileIOProperties.MULTIPART_SIZE_DEFAULT), rejected below the 5 MiB S3 minimum for a non-final part.OpenDalStorage::S3applies it throughwrite_options/writer_options. Other backends keep OpenDAL's defaults.Are these changes tested?
FileWrite::writeis split into the configured number of upload parts, counted from the multipart ETag suffix.mc admin trace: a 160 MiB Parquet write previously issued one request, now issues 5 x 32 MiB parts plus a remainder.AI Disclosure