fix(cpp): preserve vertex IDs for nonzero builder starts - #970
Open
1fanwang wants to merge 6 commits into
Open
Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Writing vertices with a builder that starts after vertex
0currently corrupts their IDs and serialized rows. The first auto-assigned vertex gets ID0instead of the requested starting ID, while an explicit global ID can create empty rows and move the payload to another ID.Fixes #954.
What changes are included in this PR?
Convert explicit global IDs to local vector offsets before storing vertices, then restore the global ID on the vertex. The builder now enforces the nonnegative, chunk-aligned start and lower-bound index invariants under every validation level.
Are these changes tested?
The existing
Test_vertices_buildernow covers auto-assigned and explicit IDs with a nonzero start, verifies the persisted_graphArVertexIndexvalues, and checks invalid starts and below-start IDs under the default validation level.Regression evidence
The regression test from this PR was first compiled against current
mainat0e2bb53a7d273f70dfbac7e4a915911ceb27748d:The same command at PR head
6113123c4d9423ca75773d36e7bbcbceded6b5acpasses:Are there any user-facing changes?
Yes. Vertices written by a builder with a nonzero start now retain their requested global IDs without emitting phantom rows. Invalid start and vertex indices return an index error instead of producing corrupt output.
Checklist