[Fix] Address aligned memory accounting Sonar issues

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java

@@ -314,9 +314,9 @@
 
     ensureMemTable(infoForMetrics);
     workMemTable.checkDataType(insertRowNode);
-    AlignedTVListRamCostSnapshot alignedRamCostSnapshot =
+    AlignedTvListRamCostSnapshot alignedRamCostSnapshot =
         insertRowNode.isAligned()
-            ? new AlignedTVListRamCostSnapshot(workMemTable, insertRowNode.getDeviceID())
+            ? new AlignedTvListRamCostSnapshot(workMemTable, insertRowNode.getDeviceID())
             : null;
 
     long[] memIncrements;
@@ -392,7 +392,7 @@
         pointInserted = workMemTable.insert(insertRowNode);
       }
     } finally {
-      reconcileAlignedTVListRamCost(alignedRamCostSnapshot, memIncrements[0]);
+      reconcileAlignedTvListRamCost(alignedRamCostSnapshot, memIncrements[0]);
     }
 
     // Update start time of this memtable
@@ -424,10 +424,10 @@
         alignedDeviceIds.add(insertRowNode.getDeviceID());
       }
     }
-    AlignedTVListRamCostSnapshot alignedRamCostSnapshot =
+    AlignedTvListRamCostSnapshot alignedRamCostSnapshot =
         alignedDeviceIds.isEmpty()
             ? null
-            : new AlignedTVListRamCostSnapshot(workMemTable, alignedDeviceIds);
+            : new AlignedTvListRamCostSnapshot(workMemTable, alignedDeviceIds);
 
     long memControlStartTime = System.nanoTime();
     if (insertRowsNode.isMixingAlignment()) {
@@ -524,7 +524,7 @@
         }
       }
     } finally {
-      reconcileAlignedTVListRamCost(alignedRamCostSnapshot, alignedMemTableIncrement);
+      reconcileAlignedTvListRamCost(alignedRamCostSnapshot, alignedMemTableIncrement);
     }
 
     tsFileResource.updateProgressIndex(insertRowsNode.getProgressIndex());
@@ -639,6 +639,7 @@
    * @param rangeList start and end index list of rows to be inserted in insertTabletPlan
    * @param results result array
    */
+  @SuppressWarnings("java:S6541") // Keep ordered write-path state updates together.
   public void insertTablet(
       InsertTabletNode insertTabletNode,
       List<int[]> rangeList,
@@ -754,7 +755,7 @@
         }
       }
     } finally {
-      reconcileAlignedTVListRamCost(alignedRamCostSnapshot, memIncrements[0]);
+      reconcileAlignedTvListRamCost(alignedRamCostSnapshot, memIncrements[0]);
     }
     tsFileResource.updateProgressIndex(insertTabletNode.getProgressIndex());
 
@@ -923,7 +924,8 @@
     return new long[] {memTableIncrement, textDataIncrement, chunkMetadataIncrement};
   }
 
-  @SuppressWarnings("squid:S3776") // high Cognitive Complexity
+  // This estimator is one stateful pass over the incoming aligned rows.
+  @SuppressWarnings({"squid:S3776", "java:S6541"})
   private long[] checkAlignedMemCostAndAddToTspInfoForRows(List<InsertRowNode> insertRowNodeList)
       throws WriteProcessException {
     // Fixed-size TVList structures and materialized value primitive arrays.
@@ -1250,6 +1252,7 @@
    * when the tablet has at least one successful non-null value in that block and the working TVList
    * has not already allocated its value array.
    */
+  @SuppressWarnings("java:S107") // Parameters mirror the tablet write representation.
   private static long calculateTabletValueArrayMemCost(
       AlignedWritableMemChunk alignedMemChunk,
       String[] measurementIds,
@@ -1366,8 +1369,8 @@
                 && columnCategories[index] == TsTableColumnCategory.FIELD);
   }
 
-  private void reconcileAlignedTVListRamCost(
-      AlignedTVListRamCostSnapshot snapshot, long estimatedMemTableIncrement) {
+  private void reconcileAlignedTvListRamCost(
+      AlignedTvListRamCostSnapshot snapshot, long estimatedMemTableIncrement) {
     if (snapshot == null) {
       return;
     }
@@ -1415,14 +1418,14 @@
     private final Set<IDeviceID> deviceIds;
     private final long ramCostBeforeWrite;
 
-    AlignedTVListRamCostSnapshot(IMemTable memTable, IDeviceID deviceId) {
+    AlignedTvListRamCostSnapshot(IMemTable memTable, IDeviceID deviceId) {
       this.memTable = memTable;
       this.deviceId = deviceId;
       this.deviceIds = null;
       this.ramCostBeforeWrite = getRamCost(memTable, deviceId);
     }
 
-    AlignedTVListRamCostSnapshot(IMemTable memTable, Set<IDeviceID> deviceIds) {
+    AlignedTvListRamCostSnapshot(IMemTable memTable, Set<IDeviceID> deviceIds) {
       this.memTable = memTable;
       this.deviceId = null;
       this.deviceIds = deviceIds;
@@ -1452,8 +1455,8 @@
 
       AlignedWritableMemChunk alignedMemChunk = (AlignedWritableMemChunk) memChunk;
       long ramCost = alignedMemChunk.getWorkingTVList().getRamSize();
-      for (AlignedTVList sortedTVList : alignedMemChunk.getSortedList()) {
-        ramCost += sortedTVList.getRamSize();
+      for (AlignedTVList sortedTvList : alignedMemChunk.getSortedList()) {
+        ramCost += sortedTvList.getRamSize();
       }
       return ramCost;
     }

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/AlignedTVList.java

@@ -185,7 +185,7 @@ public TVList getTvListByColumnIndex(
         int materializedArrayCount = materializedValueArrayCounts[columnIndex];
         alignedTvList.materializedValueArrayCounts[i] = materializedArrayCount;
         alignedTvList.materializedValueArrayMemCost +=
-            (long) materializedArrayCount * valueListArrayMemCost(dataTypeList.get(i));
+            materializedArrayCount * valueListArrayMemCost(dataTypeList.get(i));
       }
     }
 
@@ -1095,7 +1095,7 @@ private BitMap getBitMap(int columnIndex, int arrayIndex) {
         columnBitMaps.add(null);
       }
       bitMaps.set(columnIndex, columnBitMaps);
-      materializedBitmapMemoryCost += (long) columnBitMaps.size() * bitmapReferenceRamCost();
+      materializedBitmapMemoryCost += columnBitMaps.size() * bitmapReferenceRamCost();
     }
 
     // if the bitmap in arrayIndex is null, init the bitmap
@@ -1138,7 +1138,7 @@ public synchronized RamInfo calculateRamSize() {
   }
 
   public synchronized long getRamSize() {
-    return (long) timestamps.size() * alignedTvListArrayMemCostWithoutPrimitiveArrays()
+    return timestamps.size() * alignedTvListArrayMemCostWithoutPrimitiveArrays()
         + materializedValueArrayMemCost
         + materializedBitmapMemoryCost;
   }
@@ -1152,7 +1152,7 @@ private static long calculateBitmapRamCost(List<List<BitMap>> bitMaps) {
       if (columnBitMaps == null) {
         continue;
       }
-      size += (long) columnBitMaps.size() * bitmapReferenceRamCost();
+      size += columnBitMaps.size() * bitmapReferenceRamCost();
       for (BitMap bitMap : columnBitMaps) {
         if (bitMap != null) {
           size += bitMap.ramBytesUsed();
@@ -1229,19 +1229,6 @@ public long alignedTvListArrayMemCostWithoutPrimitiveArrays() {
         + (indices != null ? (long) PrimitiveArrayManager.ARRAY_SIZE * Integer.BYTES : 0);
   }
 
-  private void refreshArrayMemCostWithoutPrimitiveArrays() {
-    long size = alignedTvListArrayMemCost();
-    if (indices != null) {
-      size -= (long) PrimitiveArrayManager.ARRAY_SIZE * Integer.BYTES;
-    }
-    for (TSDataType dataType : dataTypes) {
-      if (dataType != null) {
-        size -= valueListArrayMemCost(dataType);
-      }
-    }
-    arrayMemCostWithoutPrimitiveArraysAndIndex = size;
-  }
-
   public static long alignedTvListArrayMemCostWithoutPrimitiveArrays(
       TSDataType[] types, TsTableColumnCategory[] columnCategories) {
     long size = alignedTvListArrayMemCost(types, columnCategories);
@@ -1255,6 +1242,19 @@ public static long alignedTvListArrayMemCostWithoutPrimitiveArrays(
     return size;
   }
 
+  private void refreshArrayMemCostWithoutPrimitiveArrays() {
+    long size = alignedTvListArrayMemCost();
+    if (indices != null) {
+      size -= (long) PrimitiveArrayManager.ARRAY_SIZE * Integer.BYTES;
+    }
+    for (TSDataType dataType : dataTypes) {
+      if (dataType != null) {
+        size -= valueListArrayMemCost(dataType);
+      }
+    }
+    arrayMemCostWithoutPrimitiveArraysAndIndex = size;
+  }
+
   /**
    * Get the single column array mem cost by give type.
    *
@@ -2181,6 +2181,7 @@ private LazyBitMap markRowAsInvalid(
     }
 
     @Override
+    @SuppressWarnings("java:S6541") // The scan passes share hot-path cursor state.
     public TsBlock nextBatch() {
       int maxRowCountOfCurrentBatch = Math.min(rows - index, maxNumberOfPointsInPage);
       TsBlockBuilder builder = new TsBlockBuilder(maxRowCountOfCurrentBatch, dataTypeList);

iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AlignedBitmapMemoryAccountingPerformanceTest.java

@@ -242,8 +242,8 @@ private static Measurement measureWrite(Scenario scenario, int iterations) {
   private static void runReconciliation(AccountingTarget target, int iterations) {
     long correction = 0;
     for (int i = 0; i < iterations; i++) {
-      TsFileProcessor.AlignedTVListRamCostSnapshot snapshot =
-          new TsFileProcessor.AlignedTVListRamCostSnapshot(target.memTable, target.deviceId);
+      TsFileProcessor.AlignedTvListRamCostSnapshot snapshot =
+          new TsFileProcessor.AlignedTvListRamCostSnapshot(target.memTable, target.deviceId);
       correction += snapshot.getMemoryCorrection(0);
     }
     benchmarkBlackhole = correction + iterations;