refactor(runtime): extract tool schema planning and validation - #4812
Open
jackeyfaker77 wants to merge 1 commit into
Open
refactor(runtime): extract tool schema planning and validation#4812jackeyfaker77 wants to merge 1 commit into
jackeyfaker77 wants to merge 1 commit into
Conversation
Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #4779, tool schema planning and Code Mode input validation still live inside
ai-sdk-turn.ts. Extract them intotool-schema-builder.tsso they can be tested independently, while preserving existing behavior and keeping execution and settlement in their current owners.Refs #3909
Verification
Passed locally:
tool-schema-builder,code-mode-backend,tool-availability, andrequest-shapegit diff --checkNote: The full Runtime suite on Windows encountered pre-existing SQLite file-lock cleanup (EBUSY) during test teardown; all target units and affected subsystem tests pass cleanly.
Checklist
Does this PR entail a change in behavior?