Skip to content

docs(architecture): audit Desktop and frontend group against implementation #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggbdpq wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs(architecture): audit Desktop and frontend group against implementation #4816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37fcee1
docs(architecture): audit Desktop and frontend group against implemen…
ggbdpq Sep 4, 2026
729870a
Merge remote-tracking branch 'upstream/main' into docs/audit-desktop-…
ggbdpq Sep 5, 2026
91cfb86
docs: pin the two dated Astryx reviews to their audited trees
ggbdpq Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docs/astryx-alignment-inventory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
---
doc_id: astryx-alignment-inventory
title: "Astryx alignment inventory"
language: en
source_language: en
implementation_status: current
document_status: current
translation_status: source-only
last_verified: 2026-09-04
owners:
- maka-backend
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
Expand Down
14 changes: 14 additions & 0 deletions docs/astryx-full-surface-audit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
---
doc_id: astryx-full-surface-audit
title: "Astryx full surface audit"
language: en
source_language: en
implementation_status: current

@hqhq1025 hqhq1025 Sep 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Do not mark these historical audit snapshots as current

This file is still the August 9 branch audit and still states a 183-file inventory at lines 34-36, while the exact-head generator now reports 249 files. The same problem is more concrete in docs/settings-astryx-deep-review.zh-CN.md: the body remains the August 3 pre-refactor review (for example, lines 57-64 say the other 13 pages and every SettingsSection use cards), but current settings-section.tsx:37-45,97-128 implements the open row-group design and current memory/health pages already use MoreMenu and StatusDot. The newly added implementation_status: current, document_status: current, and last_verified: 2026-09-04 therefore turn historical findings into advertised current guidance. Please mark the dated review records as historical/archive (and use the same explicit pinned-record treatment consistently), or update their substantive claims to the current tree before calling them current.

document_status: current
translation_status: source-only
last_verified: 2026-09-04
owners:
- maka-backend
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
Expand All @@ -23,6 +35,8 @@ Date: 2026-08-09
Branch: `feat/astryx-surface-alignment`
Scope: every product surface under `apps/desktop/src/renderer/**` and `packages/ui/src/**` (183 inventory files).

> **Status (verified 2026-09-05):** this is an audit record pinned to the `feat/astryx-surface-alignment` branch as of 2026-08-09; its citations and the 183-file inventory describe that tree. Since then the desktop surface has grown (the exact-head inventory generator reports 247 files at re-verification) and the settings kit was rebuilt — `SettingsSection` now implements open row groups and the memory/health pages use `MoreMenu` and `StatusDot`. The findings below are kept as written.

This pass **read and analyzed** settings pages/modules, shell/chat/workbar/panels, module hubs, packages/ui compositions, and product CSS — not only inventory scripts.

## Verdict
Expand Down
19 changes: 19 additions & 0 deletions docs/frontend-architecture-astryx-review-2026-08-09.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
---
doc_id: frontend-architecture-astryx-review-2026-08-09
title: "Frontend architecture & Astryx coverage review"
language: en
source_language: en
implementation_status: current
document_status: current
translation_status: source-only
last_verified: 2026-09-04
owners:
- maka-backend
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
Expand Down Expand Up @@ -25,6 +37,13 @@
**Method:** file-level inventory regen + pattern scan + deep reads of shell/settings/modules/ui; prior art `docs/astryx-full-surface-audit.md`, `DESIGN.md`, `docs/astryx-surface-file-inventory.md`
**Evidence log:** goal scratch `frontend-review-scan.log` (inventory totals, greps, spot-checks, inventory unit tests)

> **Status (verified 2026-09-04):** this is a review record pinned to the HEAD above; its
> citations describe that tree. Since then the workbar moved under
> `apps/desktop/src/renderer/features/workbar/` (so `session-workbar.tsx` /
> `session-workbar-tabs.ts` / `use-shell-layout.ts` no longer sit at their cited paths)
> and the Astryx core patch is now `patches/@astryxdesign+core+0.5.2.patch`. The findings
> tables below are kept as written.

---

## Executive verdict
Expand Down
12 changes: 12 additions & 0 deletions docs/frontend-css-governance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
---
doc_id: frontend-css-governance
title: "Frontend CSS governance"
language: en
source_language: en
implementation_status: current
document_status: current
translation_status: synced
last_verified: 2026-09-04
owners:
- maka-backend
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
Expand Down
12 changes: 12 additions & 0 deletions docs/frontend-css-governance.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
---
doc_id: frontend-css-governance.zh-CN
title: "Frontend CSS governance"
language: zh-CN
source_language: en
implementation_status: current
document_status: current
translation_status: synced
last_verified: 2026-09-04
owners:
- maka-backend
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
Expand Down
14 changes: 14 additions & 0 deletions docs/settings-astryx-deep-review.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
---
doc_id: settings-astryx-deep-review.zh-CN
title: "Maka 设置页深度 Review——以 Astryx 设计语言为基准"
language: zh-CN
source_language: zh-CN
implementation_status: current
document_status: current
translation_status: source-only
last_verified: 2026-09-04
owners:
- maka-backend
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
Expand All @@ -22,6 +34,8 @@
> 2026-08-03,基于 `settings/astryx-refactor` 分支(已 rebase 到最新 main)。
> 审计方式:Storybook 全页截图(中/英 × 亮/暗)+ Astryx 官方 `settings` / `settings-dialog` 模板与 `astryx docs` 原文精读。

> **状态(2026-09-05 核验):** 这是一份钉在 2026-08-03 `settings/astryx-refactor` 分支头上的评审记录,下文引用的卡片式布局等描述的都是当时的树。此后 `SettingsSection` 已重写为 open row-group 设计,memory/health 页也改用了 `MoreMenu` 与 `StatusDot`。以下发现按原文保留。

## 一、Astryx 官方设置语言到底是什么

来自 CLI vendor 的官方模板(`@astryxdesign/cli/templates/pages/settings*`)与 `astryx docs principles / layout` 原文:
Expand Down