test(desktop): move P2 coverage below Electron - #4825
Open
Astro-Han wants to merge 8 commits into
Open
Conversation
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playstories or focused UI unit tests.The former minimum-window onboarding test used
page.setViewportSize({ width: 480, height: 320 })and asserted renderer scroll geometry; it did not exercise nativeBrowserWindowminimum-size enforcement. Its replacement therefore uses the same fixed viewport in Storybook.Refs #4761
Verification
npm run build-storybook -w @maka/desktop— passednpm run smoke:storybook -w @maka/desktop— passed, 300 stories / 327 theme rendersnpm run build:with-deps -w @maka/desktop— passednpm run typecheck -w @maka/ui— passednpm run typecheck -w @maka/desktop— passednpm run check:architecture -w @maka/desktop— passed, 98 testsnode --test packages/ui/dist/session-setting-intent.test.js— passed, 9 testsnode scripts/asf-license-headers.mjs check— passedgit diff --check origin/main...HEAD— passedThe two retained Electron specs were attempted twice after a full Desktop build. Both runs timed out in the shared fixture's
electron.launchbefore either test body ran; the launched process entered a native[NSAlert runModal]JavaScript-error dialog. This is a local launch blocker, not an assertion result.AI use
Select exactly one:
Tool(s) and scope: Codex implemented the test migrations, removed retired fixture paths, ran mutation checks, and prepared this PR.
Checklist
Does this PR entail a change in behavior?