Update plugins in integration tests - #732
Conversation
adangel
left a comment
There was a problem hiding this comment.
Thanks for the PR. The update of PMD is already handled in #729.
The other versions (compilerPluginVersion, projectInfoReportsPluginVersion, jxrPluginVersion) are all used in integration tests. It still makes sense to update these and also add a comment in the pom.xml to mark them as being used by integration tests (maybe even naming the properties with prefix "it.").
- Could you revert the changes regarding PMD? (the default ruleset, the version)
- Rename the PR to "Update plugins in integration tests"
- Add the above mentioned comment for the version properties
Thanks!
|
Hey @adangel - I decided to update PMD here as well as the build breaks with a simple bump of versions as there are 2 rules marked as deprecated - it would be easier to merge this and write into the bump PR fixed by: … Let me know if you are ok with that or I should do the checklist. 👍 |
|
Ah I saw that you did it already in the Bump PR - all right - I am going to change everything tomorrow. |
f19732b to
9b1dd90
Compare
Update Maven Compiler Plugin to 3.16.0 Update Project Info Reports Plugin to 3.9.0 Update JXR Plugin to 3.6.0 Rename properties so that it is more clear that the plugins belong to integration tests
9b1dd90 to
3517497
Compare
|
Hope all is fine now. 😀 |
Description:
With this PR the following adjustments have been made:
Update Maven Compiler Plugin to 3.16.0
Update Project Info Reports Plugin to 3.9.0
Update JXR Plugin to 3.6.0
Rename properties so that it is more clear that the plugins belong to integration tests
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.