Skip to content

Update plugins in integration tests - #732

Open
klopfdreh wants to merge 1 commit into
apache:masterfrom
klopfdreh:feature/depupdates
Open

Update plugins in integration tests#732
klopfdreh wants to merge 1 commit into
apache:masterfrom
klopfdreh:feature/depupdates

Conversation

@klopfdreh

@klopfdreh klopfdreh commented Sep 6, 2026

Copy link
Copy Markdown
Member

Description:

With this PR the following adjustments have been made:

Update Maven Compiler Plugin to 3.16.0
Update Project Info Reports Plugin to 3.9.0
Update JXR Plugin to 3.6.0
Rename properties so that it is more clear that the plugins belong to integration tests


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The update of PMD is already handled in #729.

The other versions (compilerPluginVersion, projectInfoReportsPluginVersion, jxrPluginVersion) are all used in integration tests. It still makes sense to update these and also add a comment in the pom.xml to mark them as being used by integration tests (maybe even naming the properties with prefix "it.").

  • Could you revert the changes regarding PMD? (the default ruleset, the version)
  • Rename the PR to "Update plugins in integration tests"
  • Add the above mentioned comment for the version properties

Thanks!

@adangel adangel added the dependencies Pull requests that update a dependency file label Sep 7, 2026
@klopfdreh

Copy link
Copy Markdown
Member Author

Hey @adangel - I decided to update PMD here as well as the build breaks with a simple bump of versions as there are 2 rules marked as deprecated - it would be easier to merge this and write into the bump PR fixed by: …

Let me know if you are ok with that or I should do the checklist. 👍

@klopfdreh

Copy link
Copy Markdown
Member Author

Ah I saw that you did it already in the Bump PR - all right - I am going to change everything tomorrow.

@klopfdreh klopfdreh changed the title Update dependencies including pmd version Update plugins in integration tests Sep 7, 2026
Update Maven Compiler Plugin to 3.16.0
Update Project Info Reports Plugin to 3.9.0
Update JXR Plugin to 3.6.0
Rename properties so that it is more clear that the plugins belong to integration tests
@klopfdreh

Copy link
Copy Markdown
Member Author

Hope all is fine now. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants