Drop the legacy local repository from the executor request and its test - #158
Open
slachiewicz wants to merge 2 commits into
Open
Drop the legacy local repository from the executor request and its test#158slachiewicz wants to merge 2 commits into
slachiewicz wants to merge 2 commits into
Conversation
slachiewicz
added
dependencies
This comment was marked as outdated.
This comment was marked as outdated.
slachiewicz
marked this pull request as ready for review
August 16, 2026 10:57
slachiewicz
changed the title
slachiewicz
force-pushed
the
drop-maven-compat
branch
from
August 23, 2026 05:57
76b4562 to
d9b8e98
Compare
slachiewicz
changed the title
slachiewicz
added
java
slachiewicz
force-pushed
the
drop-maven-compat
branch
from
August 23, 2026 06:05
d9b8e98 to
437f61e
Compare
MavenReportExecutorRequest.localRepository, deprecated in MSHARED-1207, is read by nothing. Removing it lets the test drop the legacy repository plumbing too: the request populator already builds the ArtifactRepository -- populateFromSettings takes the path from the effective settings, populateDefaults falls back to the user default. Only surefire's localRepository override stays applied by hand, because ASF Jenkins builds with mavenLocalRepo '.repository'. The version goes to 2.1.0-SNAPSHOT, since dropping public API is not a patch release. The report assertions move to MavenReport.getOutputPath(), which reporting-api 4.0.0 added as a default method returning getOutputName(). Deprecation warnings in the test go 8 to 3; the rest are structural, since every Maven 3 MavenSession constructor is deprecated and populateFromSettings has no Maven 3 replacement. maven-compat stays while mavenVersion is 3.6.3: maven-core 3.6.3 injects the legacy org.apache.maven.repository.RepositorySystem into DefaultProjectBuildingHelper and only maven-compat implements it. The field moved to MavenRepositorySystem in maven-core 3.9.12. maven-javadoc-plugin 3.4.0 needed RepositoryMetadataManager, also maven-compat-only, so the pin moves to 3.12.0.
slachiewicz
force-pushed
the
drop-maven-compat
branch
from
August 23, 2026 06:17
437f61e to
1747a5c
Compare
Member
|
Is it not simillary to - #159 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MavenReportExecutorRequest.localRepository, deprecated in MSHARED-1207, is read by nothing. Removing it lets the test drop the legacy repository plumbing as well: the request populator already builds theArtifactRepository—populateFromSettingstakes the path from the effective settings,populateDefaultsfalls back to~/.m2/repository, which is the value the test was assembling by hand out ofMavenCli.USER_MAVEN_CONFIGURATION_HOME. Only surefire'slocalRepositoryoverride stays applied by hand, and it has to: ASF Jenkins builds this withmavenLocalRepo: '.repository', so the build's repository is not the user's. The version goes to 2.1.0-SNAPSHOT, since dropping public API is not a patch release.The report assertions move to
MavenReport.getOutputPath(), which reporting-api 4.0.0 added as a default method returninggetOutputName(). That takes the test's deprecation warnings from 8 to 3; the rest are structural — every Maven 3MavenSessionconstructor is deprecated, andpopulateFromSettingshas no Maven 3 replacement.maven-compat has to stay while
mavenVersionis 3.6.3: maven-core 3.6.3 injects the legacyorg.apache.maven.repository.RepositorySystemintoDefaultProjectBuildingHelperand only maven-compat implements it, so without the dependency 3 of the 4 tests fail withNo implementation for org.apache.maven.repository.RepositorySystem was bound. maven-core moved that field toMavenRepositorySystemin 3.9.12, which is what a removal would cost; a pom comment records that instead.maven-javadoc-plugin 3.4.0 needed
RepositoryMetadataManager, also maven-compat-only, so the pin moves to 3.12.0.Verified:
mvn verify→ 4 tests and 5 ITs, 0 failures.This change was created with AI assistance.