[MSHADE-156] Allow non relocating string literals - #249
Conversation
|
Seems this also addresses MSHADE-153. |
|
Resolve #518 |
1 similar comment
|
Resolve #518 |
|
can you merge with master? |
elharo
left a comment
There was a problem hiding this comment.
This feels like it needs some additions to the docs somewhere. Adding a property without documenting it is unlikely to help folks.
| * @param entityName entity name to be mapped | ||
| * @param mapPaths map "slashy" names like paths or internal Java class names, e.g. {@code com/acme/Foo}? | ||
| * @param mapPackages map "dotty" names like qualified Java class or package names, e.g. {@code com.acme.Foo}? | ||
| * @param mapLiterals map string literals, e.g. {@code "com.acme.Foo"}? |
|
|
||
| @Test | ||
| public void testShaderWithoutStringLiterals() throws Exception { | ||
| Shader s = newShader(); |
|
The last CI run on this branch was 2025-09-25, and GitHub has deleted the logs since, so there's no way to tell whether the change still builds against master. A rebase triggers a fresh run and makes the state readable again. If you'd rather not carry it forward, closing is equally useful — the PR isn't being ignored, it's unreadable. The branch also conflicts with master now, so that needs resolving before CI can say anything. Say the word if you'd like a hand with it. This comment was created with AI assistance. |
Notes
Jira issue: MSHADE-156
Add the option to skip relocating string literals. Currently this is not possible and the only available solution is to create a "fake" relocation pattern to prevent such behavior, example.
This change adds a new property
skipStringLiteralwhich still relocates the prefix instances but not the string literals.Testing
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSHADE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MSHADE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.