Fix #12589: fix operator precedence for BOM import dependency filtering - #12914
Closed
gnodet wants to merge 1 commit into
Closed
Fix #12589: fix operator precedence for BOM import dependency filtering#12914gnodet wants to merge 1 commit into
gnodet wants to merge 1 commit into
Conversation
The condition `!("pom".equals(type) && "import".equals(scope)) || "bom".equals(type)`
evaluates as `!(pom AND import) OR bom`, which causes BOM-type dependencies to always
be skipped via `continue`. The intended logic is `!((pom AND import) OR bom)` — skip
anything that is NOT a pom/import and NOT a bom. Fixed by moving the closing parenthesis
to wrap the entire OR expression under the negation.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing in favor of #12722 which fixes the same issue (#12589) more completely — it also updates the validator to accept |
Contributor
Author
|
Reopening: |
Contributor
Author
|
Closing: will fix PR #12722 directly instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultModelBuilder.importDependencyManagement()where BOM-type dependencies were always skipped!(pom AND import) OR bomincorrectly evaluates so thatbomtype dependencies always hitcontinue!((pom AND import) OR bom)to correctly skip only non-import, non-BOM dependenciesTest plan
mvn testpasses inimpl/maven-implmodule (493 tests, 0 failures)🤖 Generated with Claude Code