graphics/pdcurs34: Build fixes for wide characters code path - #3731
Open
000exploit wants to merge 1 commit into
Open
graphics/pdcurs34: Build fixes for wide characters code path#3731000exploit wants to merge 1 commit into
000exploit wants to merge 1 commit into
Conversation
xiaoxiang781216
previously approved these changes
Aug 17, 2026
Contributor
|
@000exploit please fix all warnings except “Mixed case identifier found”: |
Signed-off-by: 000exploit <illialoo99@gmail.com>
Author
|
@xiaoxiang781216 weird tool, to be honest. Fixed everything it complained about and force-pushed new commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed pdcurses build failures when wide character support is enabled. Some code paths had diverged from upstream pdcurses and did not compile correctly. Updated them to match the upstream.
Impact
This change does not affect users who do not enable wide character support in pdcurses.
Testing
Tested on a Radxa Orion O6 ARM64 host with a RISC-V
rv-virttarget running under RVVM.