Skip to content

graphics/pdcurs34: Build fixes for wide characters code path - #3731

Open
000exploit wants to merge 1 commit into
apache:masterfrom
000exploit:master
Open

graphics/pdcurs34: Build fixes for wide characters code path#3731
000exploit wants to merge 1 commit into
apache:masterfrom
000exploit:master

Conversation

@000exploit

Copy link
Copy Markdown

Summary

Fixed pdcurses build failures when wide character support is enabled. Some code paths had diverged from upstream pdcurses and did not compile correctly. Updated them to match the upstream.

Impact

This change does not affect users who do not enable wide character support in pdcurses.

Testing

Tested on a Radxa Orion O6 ARM64 host with a RISC-V rv-virt target running under RVVM.

@xiaoxiang781216

Copy link
Copy Markdown
Contributor

@000exploit please fix all warnings except “Mixed case identifier found”:

0b7519594 graphics/pdcurs34: Fixes for wide char build
../nuttx/tools/checkpatch.sh -c -u -m -g 84ffa84e241f116f514257eb2d0efa7e87470ce7..HEAD
❌ Missing Signed-off-by
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:2:1: error: Relative file path does not match actual file
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:115:9: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:128:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:277:1: error: Blank line precedes right brace at line
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:295:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:312:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:339:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:349:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:387:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:551:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:568:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:595:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_getstr.c:605:34: error: Mixed case identifier found
Used config files:
    1: .codespellrc
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:151:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:205:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:250:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:272:2: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:276:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:348:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:358:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:365:2: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:391:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:403:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:415:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:426:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:447:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:468:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:482:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:505:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:598:5: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:601:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:652:5: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:655:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:676:4: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:680:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:709:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:774:34: error: Mixed case identifier found
/home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_slk.c:58: useable ==> usable
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:2:1: error: Relative file path does not match actual file
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:115:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:117:30: error: Multiple data definitions
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:117:36: error: Right bracket not on separate line
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:211:34: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:213:34: error: Multiple data definitions
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:213:40: error: Right bracket not on separate line
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:243:4: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:302:7: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:317:19: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/graphics/pdcurs34/pdcurses/pdc_util.c:336:7: error: Mixed case identifier found
Some checks failed. For contributing guidelines, see:
  https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
Error: Process completed with exit code 1.

Signed-off-by: 000exploit <illialoo99@gmail.com>
@000exploit

Copy link
Copy Markdown
Author

@xiaoxiang781216 weird tool, to be honest. Fixed everything it complained about and force-pushed new commit.

@github-actions github-actions Bot added Size: S and removed Size: XS labels Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants