PHOENIX-7991 Tag per-HA-group replication metric sources with the ha_group tag - #2606
Open
Himanshu-g81 wants to merge 1 commit into
Open
PHOENIX-7991 Tag per-HA-group replication metric sources with the ha_group tag#2606Himanshu-g81 wants to merge 1 commit into
Himanshu-g81 wants to merge 1 commit into
Conversation
Himanshu-g81
marked this pull request as ready for review
August 21, 2026 12:16
…group tag Register the ha_group Metrics2 tag on the six per-HA-group replication log metric sources (log group, processor, discovery replay/forwarder, tracker replay/forwarder) so their series can be sliced per HA group downstream, matching the existing HAGroupStore metrics source. Move the shared HA_GROUP_TAG_NAME / HA_GROUP_TAG_DESC constants out of the HAGroupStoreMetricsSource interface into a new module-neutral org.apache.phoenix.metrics.MetricConstants (phoenix-core-client) so both the client HAGroupStore source and the server-side replication sources reference a single definition.
Himanshu-g81
force-pushed
the
PHOENIX-7991
branch
from
August 21, 2026 13:19
fe13ae1 to
2a6dade
Compare
tkhurana
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the
ha_groupMetrics2 tag on the six per-HA-group replication log metric sources so their series can be sliced per HA group downstream (Argus), matching the existingHAGroupStoresource.Also moves the shared
HA_GROUP_TAG_NAME/HA_GROUP_TAG_DESCconstants out of theHAGroupStoreMetricsSourceinterface into a new module-neutralorg.apache.phoenix.metrics.MetricConstantsso both client and server sources share one definition. Tested viaMetricsReplicationLogSourceHaGroupTagTest(6 cases) + updatedHAGroupStoreMetricsSourceImplTest.