Compare whole fields in the lock-step branch of HTTPFields.== - #152
Open
lenamonj wants to merge 1 commit into
Open
Compare whole fields in the lock-step branch of HTTPFields.==#152lenamonj wants to merge 1 commit into
lenamonj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lock-step branch of
HTTPFields.==compared onlynameandvalue, while the pending branch,isEqualByNameIndexandhash(into:)compare wholeHTTPFieldvalues. Two lists differing only inindexingStrategy, or in raw bytes that decode to the same replacement character, compared equal on that path and unequal on every other, and hashed differently, so aSetcould hold both.The branch now compares whole fields. The new test fails on main and passes with the change;
swift testwith the CI flags is green.