Skip to content

style: apply rustfmt to the BES tracing sink - #1401

Merged
thesayyn merged 1 commit into
claude/axl-cli-otel-test-spans-52xxpxfrom
claude/cli-otel-spans-formatting-gb8glm
Aug 26, 2026
Merged

style: apply rustfmt to the BES tracing sink#1401
thesayyn merged 1 commit into
claude/axl-cli-otel-test-spans-52xxpxfrom
claude/cli-otel-spans-formatting-gb8glm

Conversation

@thesayyn

Copy link
Copy Markdown
Member

Fixes the format-gha / format-gha-debug / format-format-repeat-task failures on #1369. The format task reported exactly one unformatted file, crates/axl-runtime/src/engine/bazel/sink/tracing.rs:

  • both TestStatus::try_from(...).unwrap_or(...) bindings wrapped on the wrong side of the call
  • the multi-argument assert_eq!s in the new tests exceeded the line width
  • the Timestamp { seconds: 42, nanos: 0 } literal needed expanding

Produced by running cargo fmt --all; cargo fmt --all -- --check is now clean across the workspace.

Based on claude/axl-cli-otel-test-spans-52xxpx so the diff is only the formatting change. Merging it into that branch turns #1369's format checks green.

Changes are visible to end-users: no

Whitespace and line wrapping only — no behavior change.

Test plan

  • cargo fmt --all -- --check passes with no diff
  • cargo test -p axl-runtime --lib engine::bazel::sink::tracing — 6 passed, 0 failed

Generated by Claude Code

The format CI task flagged
`crates/axl-runtime/src/engine/bazel/sink/tracing.rs`: the two
`TestStatus::try_from` bindings wrapped on the wrong side of the call, the
multi-argument `assert_eq!`s exceeded the line width, and the `Timestamp`
struct literal needed expanding.

Formatting only — no behavior change.
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9fdb7172-a79a-48d9-90b4-53cd7b5f9830

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thesayyn
thesayyn merged commit 73f9f29 into claude/axl-cli-otel-test-spans-52xxpx Aug 26, 2026
1 of 2 checks passed
@thesayyn
thesayyn deleted the claude/cli-otel-spans-formatting-gb8glm branch August 26, 2026 18:44

Copy link
Copy Markdown
Member Author

Closing as redundant — the rustfmt commit (73f9f29) was pushed directly onto claude/axl-cli-otel-test-spans-52xxpx instead, so it now rides along with #1369 and re-triggers its CI.

This PR could never have been verified on its own: ci-workflows.yaml triggers on pull_request: branches: [main], and this one targeted a feature branch, so none of the aspect / * checks ever registered against its head.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants