test: Pin UTC data type to number in type regression tests - #50
Merged
Merged
Conversation
The UTC data type was added without a type-level assertion, so a regression in its index.d.ts declaration would go unnoticed. Add it to the primitives struct alongside the other numeric types. Refs #49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
DataTypes.UTCto the primitives struct intest/types-test.tsand pins its parsed value tonumber.#49 added the UTC data type but no type-level assertion, so a regression in its
index.d.tsdeclaration would compile fine and only surface downstream. Commenting out the declaration now failsnpm run typecheck.Refs #49