feat: add explicit app build configuration - #670
Draft
jeroenwienk wants to merge 1 commit into
Draft
jeroenwienk wants to merge 1 commit into
jeroenwienk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript apps that install TypeScript only for JSDoc checking currently trigger compilation and TypeScript driver templates. Add a boolean
homey.buildsetting in the app'spackage.jsonso apps can control their build step independently of their source language.truerunsnpm run buildfrom the app directory without TypeScript-specific checks. Scripts write generated deployment files into the prepared.homeybuilddirectory.falseskips the app build script while preserving Compose, source/dependency copying, and normal validation.Driver templates infer the source language from the entry file or root app files, with the existing dependency fallback and ESM branch preserved. New JavaScript apps set
homey.build: false; new TypeScript apps set it totrue. The README documents the build contract and JSDoc use case. Native TypeScript execution and a future opt-in default remain separate work.Validation: all 323 tests pass with
npm run test:coverage, including CI coverage thresholds. Focused fixtures cover real npm build execution, failures, legacy configuration checks, preprocessing, templates, and scaffolding.npm run lintandnpm run prettier:checkalso pass.