fix(time): Correct Time cluster attribute ids and unblock type generation - #217
Merged
Merged
Conversation
The Time cluster uses ZCLDataTypes.UTC, which was only added in 1.3.0. With the lockfile still pinned to 1.2.1, npm ci resolved a version where that type is undefined. Refs #216
ValidUntilTime is 0x0009 in the ZCL spec, not 0x0008. Because attributesById is keyed by id, the duplicate dropped lastSetTime from the lookup: reads and reports for 0x0008 decoded as validUntilTime, and 0x0009 was unknown. Refs #216
zclDataTypeToValueType had no case for UTC, so generate-types threw "Unknown ZCL type UTC" as soon as a cluster used it. The type generation workflow has been failing on master since the Time cluster attributes landed, leaving index.d.ts without them. Refs #216
RobinBol
force-pushed
the
fix/time-cluster-attributes
branch
from
August 28, 2026 13:43
fe1d25d to
dbb458b
Compare
RobinBol
marked this pull request as ready for review
August 28, 2026 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #216.
validUntilTimewas id0x0008, same aslastSetTime.attributesByIdis keyed by id, so0x0008decoded asvalidUntilTimeand0x0009was unknown. ZCL r8 table 3-69 puts it at0x0009.generate-typeshad no case forUTCand threw, so the workflow has failed on every master push since Add Time cluster attributes #216. Regeneratedindex.d.tshere.@athombv/data-typeswas pinned to^1.2.1in the lockfile, whereZCLDataTypes.UTCdoes not exist.